• RuntimesUnity

  • Do Adaptive Probe Volumes (URP) not ork with the URP/Skeletal Lit shader?

    anglais

  • Mmercuito

    • Message #1
    • Modifié
    • Ce post est en anglais

    I've been trying to get my sprite to get global illumination from the APV light probes, but no dice.
    If I turn Light Probe Groups on, then the Skeleton seems to get the global illumination lighting just fine.

    Could you maybe point in where in the Skeleton Lit shader I'd have to make changes to (if any) to get the lighting from the adaptive probes as well?

    I'll try and upload a video that could better communicate the issue.

    Related Discussions
    ...

    Adaptive Probe Volumes (APV) in URP may not work directly with the URP/Skeleton Lit shader due to the way the shader handles lighting. The Skeleton Lit shader is designed to work with specific lighting setups, and it might not automatically support APV without modifications. To integrate APV lighting, you would likely need to modify the shader to include support for the specific lighting calculations used by APV. This could involve adjusting how the shader samples and applies light data from the probes. Unfortunately, without specific details on the APV implementation, it's challenging to provide exact code changes. You might want to start by examining how the shader handles light probes and adapt it to include APV data.

    • Harald

    • Message #3
    • Ce post est en anglais

    @mercuito Thanks for bringing this to our attention, sorry for the troubles. We'll have a look at how APV light probes are implemented on the shader side and whether they can be supported by the existing shaders.

    For the meantime: Have you tried the Universal Render Pipeline/Spine/Sprite shader?

      Harald Hey, thanks for the reply. I was digging around in there and while I think the Sprite shader seems to be more featured, I don't think it handles the new volume probes. I changed the SkeletonLit-ForwardPass-URP vertex shadera bit, I'll link an image.
      I just made it call the
      SampleProbeVolumePixel function that SAMPLE_GI gets defined as when PROBE_VOLUMES_L1/L2 get defined (which I also did in the .shader file)

      Although I do have lingering thought if, since the new volume probes are per pixel, if it's better to just do this GI baking in the fragment shader, but I think it works for now.

      Maybe you'll find the proper way to incorporate it

        One thing I still can't understand is how the stock Lit shader seems to work just fine, but it doesn't have the

        		#pragma multi_compile _ PROBE_VOLUMES_L1 PROBE_VOLUMES_L2

        line that I had to use to get the macros to use the right GI sampling functions.

        it just uses
        #pragma multi_compile _ EVALUATE_SH_MIXED EVALUATE_SH_VERTEX
        which won't work for me, so I'm clearly doing something wrong but still trying to figure out what

        nvm, their code as just being sneaky

        oh well

        • Harald

        • Message #7
        • Ce post est en anglais

        @mercuito Thanks for the additional info.

        We've just added official support for APV at the Universal Render Pipeline/Spine/Skeleton Lit shader.
        From the changelog:

        Universal Render Pipeline/Spine/Skeleton Lit shader now supports Adaptive Probe Volumes (APV) introduced in Unity 6. The shader also provides a new material property APV per Pixel to either calculate APV lighting contribution per pixel (the default) or per vertex.

        Issue ticket for later reference:
        EsotericSoftware/spine-runtimes2750

        A new 4.2 URP Shaders UPM package zip package is available for download here as usual:
        https://esotericsoftware.com/spine-unity-download

        Note that support for APV at the Universal Render Pipeline/Spine/Sprite shader is not yet added. It will be in the near future though.

          • Harald

          • Message #8
          • Ce post est en anglais

          Harald Note that support for APV at the Universal Render Pipeline/Spine/Sprite shader is not yet added. It will be in the near future though.

          APV support has now also been implemented for the Universal Render Pipeline/Spine/Sprite shader as well. APV lighting contribution is automatically calculated per pixel at this shader.

          A new 4.2 URP Shaders UPM package zip package is available for download again:
          https://esotericsoftware.com/spine-unity-download

            Amazing, thanks so much!
            I did more digging around after looking at your commit - trying to see if EVALUATE_SH_MIXED/VERTEX was needed at all with the APV system, and I think it was the right call to just avoid using those keywords all together. Also they only seem to be 'define-able' if you actually set the option here in the Render Pipeline settings:

            which allows you to define them in the .shader files with the #pragma multi-compile line
            However defining them will make it so SAMPLE_GI will end up just returning the vertexSH, and OUTPUT_SH4 will be the only way of getting GI data...so I don't even see the point of using MIXED if it seems to just switch to all vertex or all pixel. Anyways enough rambling, and again, thank you for the quick update, have a good one!

              • Harald

              • Message #10
              • Ce post est en anglais

              mercuito Very glad the changes helped!

              Thanks very much for sharing your careful examination and thoughts, much appreciated! Our current Spine URP Shaders code is a result of supporting multiple URP versions through the same code, so sometimes URP wrapper functions end up being inlined just for compatibility reasons. But as Unity is changing the code around OUTPUT_SH almost every version, please do let us know if anything is missing and unsupported.