Ce site est optimisé pour être consulté depuis un navigateur moderne dans lequel JavaScript est activé.

[Unity] BoneComponent doesn't flip with negative scale

SullyTheStrange

After thinking about this I'm not sure which functionality you'd like to have

after all, it does flip properly using FlipX, the intended method. But unfortunately that doesn't affect child objects like a negative scale does, so it would be nice if BoneComponents would flip using both methods, because the other option is using FlipX and then manually flipping all of the children. Not too bad, but inconvenient. 🙂 What do you guys think?

SullyTheStrange

Pharan

What's your object hierarchy setup?

Though, the fact is that making BoneComponent cater to all the different possible conditions people will use it in will bloat it terribly for the people who use it in really simple cases. Though if the fix is simple enough, I think it might make it into the repo.

In other cases, better to modify it according to how you're using it.

To that end, maybe we can figure out what you need to do to the code.
If the thing with the BoneComponent is already a child of your SkeletonAnimation/SkeletonRenderer, this is likely a simple fix. We just need to remove some of the logic that flips it manually with flipX and leave it to the hierarchy to inherit the negative scale.

Just FYI:
The reason why using flipX is ideal for simple cases vs negative scale is because negative scale (or any kind of scaling on a Transform) will break dynamic batching for renderables being scaled.

SullyTheStrange

Oh oops, I described that badly, the BoneComponent object is a child of the SkeletonAnimation. I didn't mean to say the BoneComponent should flip to match its object even if it isn't a child, I can see how that could be complicated, I just meant this specific setup where you would expect it to inherit negative scale.

And I wasn't aware of the dynamic batching issue, that certainly makes sense.

Pharan

Okay, so the BoneComponent object is the immediate child of its target SkeletonAnimation?
Let me check where to fix this. Should be simple.
Though I'll get back to you in about an hour or so. I'm just heading out for lunch.

Actually, if you have the latest version of BoneComponent, you can uncheck the "Follow Flips" checkbox. Does that fix it?
If not, tell how it goes wrong in this case.

What unchecking the checkbox does is simply disabling
If not, you can find this part of the code:

if(followFlips) {
   rotation.x = flipY ? 180f : 0f;
   rotation.y = flipX ? 180f : 0f;
} else {
   flipRotation = (flipX ^ flipY) ? -1f : 1f;
}

and just delete that whole if block.

Although the truth is, from looking at the code, it should function correctly without any changes, even if followFlips was checked. The flip correction only happens when you use flipX. If you don't change flipX, it should inherit normally as long as the BoneComponent object is an immediate child of its target SkeletonAnimation.

SullyTheStrange

Yes, it's the immediate child of its target. And it looks like I do have the latest version but that code isn't in there... Just one line, "float flipRotation = (skeleton.flipX ^ skeleton.flipY) ? -1f : 1f;", the rest isn't in either of these (I'm using tk2d):

https://github.com/EsotericSoftware/spi ... mponent.cs
https://github.com/EsotericSoftware/spi ... mponent.cs

Pharan

Ah, right. Sorry. I think Nate hasn't merged my PR yet.
Grab the latest BoneComponent here: https://github.com/pharan/spine-runtime ... ecomponent

Make sure to get the component and the editor script if you want the checkboxes.