Ce site est optimisé pour être consulté depuis un navigateur moderne dans lequel JavaScript est activé.

[cocos-c, cocos-2dx, v2.0] Double freeing bug

Skaven

In spAnimationState_clearTrack(..)

if (current->previous)
        internal->disposeTrackEntry(self, current->previous);

should be

if (current->previous)
{
        internal->disposeTrackEntry(self, current->previous);
        current->previous = 0;
}

Otherwise on some aftergoing disposals it tries to free already free'd mem

Nate

Looks like we don't need to dispose current->previous since _spTrackEntry_dispose does it now (it didn't used to). Actually, looking at this I see a problem where _spTrackEntry_dispose calls _spTrackEntry_dispose for self->previous which could abandon the rendererObject. It needs to use _spAnimationState->disposeTrackEntry, but it doesn't have an spAnimationState instance...

Fixed all that up in Git, thanks! 🙂

Skaven

It's ok now... until any mixing animation set. Then again

disposeTrackEntry

tries to access/free already free'd memory (Accessing it in

if (entry->rendererObject)

void disposeTrackEntry (spTrackEntry* entry)

Still comes from

spAnimationState_clearTrack  

{ 
 if (current->previous)
    {
        internal->disposeTrackEntry(current->previous); // <

---


  }
}

current->previous = NULL;

fixes it.

Sorry to bother, I have memory scrambler enabled for free'd memory, so I'm catching all these errors. Anyway I hope that it helps project to become even better.

Nate

Ah, sorry I thought I had taken out disposing the previous entry! Fixed now.

Not a bother at all, I appreciate you pointing out stuff like this (twice even!) so it gets fixed. 8)