• Unity

  • Editor Multiple Skins Question

    anglais

Hi, thanks for the neat API, I can combine multiple skins during runtime like this:

public void CombineSkinForSingleSA()
{
    if (skinNameList.Count != 0)
    {
        tempCombineSkin = new Skin("combinedSkin");
        for (int i = 0; i < skinNameList.Count; i++)
        {
            Skin foundSkin = sa.Skeleton.Data.FindSkin(skinNameList[i]);
            if (foundSkin != null) 
                tempCombineSkin.AddAttachments(foundSkin);
        }

    sa.Skeleton.SetSkin(tempCombineSkin);
    sa.Skeleton.SetSlotsToSetupPose();
    sa.AnimationState.Apply(sa.Skeleton);
}
}

However my artist ask me to preview/show multiple skins in unity editor today. :think:
I make a litte script with [ExecuteInEditMode] tag.
But after call the combine function, the combined skin will only stay in a few moment then back to initial state when lose focus(select other GameObject in editor) .
Is there some mechanism trying to reset the whole skelenAnimationComp?
Is it possible to keep the multiple skins editor preview result?
Thanks! 😃

Related Discussions
...

  • ara

    • Message #2
    • Modifié
    • Ce post est en anglais

    Glad that you like the API!

    You should be able to prevent any overrides by subscribing to the skeletonRenderer.OnRebuild delegate and calling your SetCustomCombinedSkin method in the callback method:
    spine-runtimes/SkeletonRenderer.cs at 3.8
    This callback hook will be called after any initialization methods which will reset the skin to the Initial Skin Name skin.

    We also have this ticket on our roadmap to support it out of the box:
    [unity] Provide component interface to set combined skins · #1633

    Harald a écrit

    Glad that you like the API!

    You should be able to prevent any overrides by subscribing to the skeletonRenderer.OnRebuild delegate and calling your SetCustomCombinedSkin method in the callback method:
    spine-runtimes/SkeletonRenderer.cs at 3.8
    This callback hook will be called after any initialization methods which will reset the skin to the Initial Skin Name skin.

    We also have this ticket on our roadmap to support it out of the box:
    [unity] Provide component interface to set combined skins · #1633

    Thanks Harald!
    I tried OnRebuild but it's not called.
    Could you please take a look at my script :think:

    Sorry to hear that it didn't solve the problem. I will have a look at it tomorrow and get back to you as soon as I figured it out.

    Ok. Thanks! 😃

    I just discovered that I recommended the wrong method, I misremembered what the proper solution was, sorry about that.

    The proper way is to set skeletonRenderer.EditorSkipSkinSync = true, as described in this posting:
    Dynamic Attachments Showing in Editor
    This prevents the SkeletonRenderer Inspector from calling the respective code parts in UpdateIfSkinMismatch.

    Harald a écrit

    I just discovered that I recommended the wrong method, I misremembered what the proper solution was, sorry about that.

    The proper way is to set skeletonRenderer.EditorSkipSkinSync = true, as described in this posting:
    Dynamic Attachments Showing in Editor
    This prevents the SkeletonRenderer Inspector from calling the respective code parts in UpdateIfSkinMismatch.

    That works as expected! Thank you for getting back to me ,really appreciate it 😃

    Glad to hear, thanks for letting us know! :nerd:

    8 mois plus tard
    skeletonRenderer.EditorSkipSkinSync = true

    Works great!

    Here is some reference code for anyone that might want to add a Skin Configuration. It has options to Apply the skins OnStart (or you can apply by calling Activate() at runtime). If you select the SkinApplicationType.ReplaceSkin and check the box for replaceSkinApplyInEditMode then it will apply the skin in Editor mode.

    Two notes:
    1) I haven't thoroughly tested this, so there could be some corner-case issues. It might be best just to use this for reference and create your own script.
    2) I'm using Odin Inspector, so the "ShowIf" and "LabelText" attributes on the replaceSkinApplyInEditMode will only work if you have Odin Inspector.

    using Sirenix.OdinInspector;
using Spine;
using Spine.Unity;
using Spine.Unity.AttachmentTools;
using System.Collections;
using System.Collections.Generic;
using UnityEngine;

[ExecuteInEditMode]
public class SpineSkinApplicator : MonoBehaviour
{
    public SkeletonAnimation targetSkeletonAnimation;
    public bool ignoreSkinNotFoundError = false;

public enum AutomaticApplicationOption { None, OnStart }
public AutomaticApplicationOption automaticApplyOption = AutomaticApplicationOption.OnStart;

public enum SkinApplicationType { ReplaceSkin, AddToSkin }
public SkinApplicationType applicationType;
[ShowIf("applicationType", SkinApplicationType.ReplaceSkin)][LabelText("Apply In Edit Mode")] public bool replaceSkinApplyInEditMode = true;

[SpineSkin(dataField = "targetSkeletonAnimation")] public List<string> skinEntries = new List<string>(1);

void Start() {
    if (Application.isPlaying == false && applicationType == SkinApplicationType.ReplaceSkin && replaceSkinApplyInEditMode) { Activate(); }
    if (Application.isPlaying == true && automaticApplyOption == AutomaticApplicationOption.OnStart) { Activate(); }
}

private void OnValidate() {

    if (Application.isPlaying) { return; }

    if (targetSkeletonAnimation == null) { targetSkeletonAnimation = GetComponent<SkeletonAnimation>(); }

    if (targetSkeletonAnimation != null) {
        if (applicationType == SkinApplicationType.ReplaceSkin && replaceSkinApplyInEditMode) {
            targetSkeletonAnimation.EditorSkipSkinSync = true;
            Activate();
        } else {
            targetSkeletonAnimation.EditorSkipSkinSync = false;
        }
    }
}

private void OnDestroy() {
#if UNITY_EDITOR
        if (targetSkeletonAnimation != null) {
            targetSkeletonAnimation.EditorSkipSkinSync = false;
        }
#endif
    }


public void Activate() {

    if(ValidTargetAndSkeleton() == false) { return; }

    switch (applicationType) {
        case SkinApplicationType.ReplaceSkin:
            ApplyAsReplace();
            break;
        case SkinApplicationType.AddToSkin:
            ApplyAsAddToSkin();
            break;
    }
}


public void ApplyAsReplace() {

    Skin buildSkin = new Skin("buildSkin");

    foreach (var skinName in skinEntries) {
        var skinCur = targetSkeletonAnimation.skeleton.Data.FindSkin(skinName);
        if (skinCur != null) {
            buildSkin.AddAttachments(skinCur);
        } else {
            if (ignoreSkinNotFoundError == false) {
                Debug.LogError("Error: skin not found, skinName: " + skinName, gameObject);
            }
        }
    }

    targetSkeletonAnimation.skeleton.SetSkin(buildSkin);
    targetSkeletonAnimation.skeleton.SetSlotsToSetupPose();
}


public void ApplyAsAddToSkin() {

    foreach(string skinName in skinEntries) {

        Skin newSkin = targetSkeletonAnimation.skeleton.Data.FindSkin(skinName);
        if (newSkin != null) {
            Skin currentSkin = targetSkeletonAnimation.skeleton.Skin;
            Skin combinedSkin = new Skin("combinedSkin");
            combinedSkin.AddSkin(currentSkin);
            combinedSkin.AddSkin(newSkin);
            targetSkeletonAnimation.skeleton.SetSkin(combinedSkin);
            targetSkeletonAnimation.skeleton.SetSlotsToSetupPose();
        } else {
            if (ignoreSkinNotFoundError == false) {
                Debug.LogError("Error: skin not found, skinName: " + skinName, gameObject);
            }
        }
    }

}

public bool ValidTargetAndSkeleton() {
    if(targetSkeletonAnimation == null) { return false; }
    return targetSkeletonAnimation.skeleton != null;
}

}

    Edit: code tweaks

    Thanks for sharing Jamez0r, much appreciated as always! 8)